Make rosidl_get_typesupport_target return -NOTFOUND instead of FATAL_ERROR #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ERROR Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI (build:
|
|
Re-run of Linux CI (now that the failing CI node has been excised): |
delete-merged-branch
bot
deleted the
sloretz__rosidl_get_typesupports_NOTFOUND
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of conditionally using typesupport targets: ros2/common_interfaces#183
It allows using
rosidl_get_typesupport_targeteven if the target doesn't exist. If it doesn't, the function sets the output variable to the expected target name ending in-NOTFOUND. That allows it to be checked with if() which evaluates any string ending with that suffix as a false constant.