Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rosidl_generator_c/cpp tests to a separate package #701

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Move rosidl_generator_c/cpp tests to a separate package #701

merged 2 commits into from
Sep 1, 2022

Conversation

jacobperron
Copy link
Member

This decouples the dependency between the generator packages and rosidl_cmake.

@jacobperron
Move rosidl_generator_c/cpp tests to a separate package
b96b663 
This decouples the dependency between the generator packages and rosidl_cmake.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

jacobperron commented Aug 11, 2022 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron
Fix file path
1999f8d 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ihasdapie
ihasdapie approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@ihasdapie ihasdapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: will need to add a <depend> tag for service_msgs as a follow-up PR to make sure nothing breaks with service introspection later.

gbiggs
gbiggs approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@gbiggs gbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out as being wrong and LGTM pending green CI.

@jacobperron
Copy link
Member Author

CI was posted above for the latest changes.

@jacobperron jacobperron merged commit 654d6f5 into rolling Sep 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/generator_test_package branch September 1, 2022 00:08
@jacobperron jacobperron mentioned this pull request Sep 1, 2022
Merged
@ihasdapie ihasdapie mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

@ihasdapie ihasdapie ihasdapie approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @gbiggs @ihasdapie