Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update comment #757

Merged
merged 3 commits into from
Jul 19, 2023
Merged

update comment #757

merged 3 commits into from
Jul 19, 2023

Conversation

iuhilnehc-ynos
Copy link
Contributor

No description provided.

update comment
4df1722 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@clalancette
use a generic meaning to avoid updating in the future
1dd1d2c 
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
emersonknapp
emersonknapp approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change - any number written in a comment inevitably becomes incorrect

@clalancette
Update other comments that do not mention the event
456d5e0 
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

Going ahead and merging this one (the timers_manager test failure is a known Windows flake).

@clalancette clalancette merged commit c72b454 into ros2:rolling Jul 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@emersonknapp emersonknapp emersonknapp approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iuhilnehc-ynos @clalancette @emersonknapp