Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased the cpplint timeout to 300 seconds #797

Merged
merged 1 commit into from Apr 4, 2024
Merged

Increased the cpplint timeout to 300 seconds #797

merged 1 commit into from Apr 4, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 4, 2024

In this nightly job I just see a cpplint timeout in rosidl_generated_cpp package

Increaing a little bit the timeout.

2: Done processing C:\ci\ws\build\rosidl_generator_tests\rosidl_generator_cpp\rosidl_generator_tests\msg\detail\strings__type_support.hpp
 2/44 Test  #2: cpplint_rosidl_generated_cpp ......................***Timeout 120.06 sec

@ahcorde
Increased the cpplint timeout to 300 seconds
a31b0a5 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 4, 2024
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 4, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Apr 4, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just curious how long usually takes though...

@ahcorde ahcorde merged commit 4088280 into rolling Apr 4, 2024
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/cpplint_timeout branch April 4, 2024 16:01
FahadRazaKhan pushed a commit to FahadRazaKhan/rosidl that referenced this pull request Apr 9, 2024
@ahcorde
Increased the cpplint timeout to 300 seconds (ros2#797)
d4d5add 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Fahad <fahad.raza@desaysv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@marcoag marcoag Awaiting requested review from marcoag

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @clalancette @fujitatomoya