Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use CMAKE_CURRENT_BINARY_DIR for arguments json #268

Merged
merged 1 commit into from
Apr 3, 2018
Merged

use CMAKE_CURRENT_BINARY_DIR for arguments json #268

merged 1 commit into from
Apr 3, 2018

Conversation

dirk-thomas
Copy link
Member

Fixes #267.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Apr 3, 2018
@dirk-thomas dirk-thomas self-assigned this Apr 3, 2018
This was referenced Apr 3, 2018
Merged
Merged
Merged
Merged
Closed
@mikaelarguedas
Copy link
Member

looks sensible to me.
Even though it should not impact our builds as these variables are the same in our case, do you have a CI job for this set of PRs?

@dirk-thomas
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mikaelarguedas
mikaelarguedas approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirk-thomas dirk-thomas merged commit 497a123 into master Apr 3, 2018
@dirk-thomas dirk-thomas deleted the location_arguments_json branch April 3, 2018 18:18
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @mikaelarguedas