Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against DELETE being predefined on Windows #401

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Guard against DELETE being predefined on Windows #401

merged 3 commits into from
Aug 30, 2019

Commits on Aug 22, 2019

  1. Guard against DELETE being predefined on Windows 

    Motivated by build errors encountered building
visualization_msgs/msg/Marker.msg.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    828006d View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Update guard against common Windows preprocessor definitions 

    Rather than undefining unconditionally at the top of the file, only undefine
if a constant by one of the common names is defined.
Also, redefine the macro after the constant has been declared using the pragma
push_macro and pop_macro.
Suppress a potential warning for popping a macro that was not previously pushed.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    f5be052 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Alphabetize 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    9b902a8 View commit details
    Browse the repository at this point in the history