Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashing backport]: Fix double free issue when initialization is failed (#423) #426

Merged
merged 1 commit into from
Dec 14, 2019

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Dec 11, 2019

Backport of #423.

Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@wjwwood
Copy link
Member

wjwwood commented Dec 13, 2019

Dashing CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented Dec 14, 2019

CI failures are from upstream linter changes, e.g.: ros2/build_farmer#255, or are known flaky, e.g. https://ci.ros2.org/job/ci_osx/7284/testReport/junit/(root)/projectroot/test_get_node_names__rmw_connext_cpp/.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit 8ec148f into dashing Dec 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the dashing-backport-423 branch December 14, 2019 02:17
@clalancette clalancette moved this from In Progress to Needs Release in Dashing Patch Release 6 Dec 19, 2019
@nuclearsandwich nuclearsandwich moved this from Needs Release to Released in Dashing Patch Release 6 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants