Support service generation on action folders #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Oct 24, 2018
| @@ -54,6 +55,8 @@ macro(rosidl_generate_dds_interfaces target) | |||
| list(APPEND _generated_msg_files "${_output_path}/${_name}_.idl") | |||
| elseif(_parent_folder STREQUAL "srv") | |||
| list(APPEND _generated_srv_files "${_output_path}/${_name}_.idl") | |||
| elseif(_parent_folder STREQUAL "action") | |||
There was a problem hiding this comment.
Do we also want another elseif block in the parent scope for the file extension? And maybe more importantly if a .srv file appears inside an action folder? E.g.
elseif(_extension STREQUAL ".srv")
if(_parent_folder STREQUAL "srv")
list(APPEND _generated_srv_files "${_output_path}/Sample_${_name}_Request_.idl")
list(APPEND _generated_srv_files "${_output_path}/Sample_${_name}_Response_.idl")
elseif(_parent_folder STREQUAL "action")
list(APPEND _generated_action_files "${_output_path}/Sample_${_name}_Request_.idl")
list(APPEND _generated_action_files "${_output_path}/Sample_${_name}_Response_.idl")
else()
...
endif()
elseif(_extension STREQUAL ".action")
# Do something here?
else()
...
endif()
|
LGTM |
sloretz
force-pushed
the
hidmic/prepare_for_action_generation
branch
from
95d65f1
to
f6bc6f5
Compare
sloretz
approved these changes
Oct 30, 2018
|
Ok, given that we have green light I'm proceeding to merge this and its related PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rosidl#301. This pull request is part of a series of pull requests that make the necessary changes to allow us to build .srv files outside an
srvfolder.connects to ros2/rosidl#301