Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python_d for test_cli_extension in Debug mode #136

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Use python_d for test_cli_extension in Debug mode #136

merged 1 commit into from
Jun 23, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jun 22, 2021

This should fix a test failure on Windows Debug where the test fails to import numpy extension modules.

https://ci.ros2.org/job/nightly_win_deb/2027/testReport/junit/(root)/projectroot/test_cli_extension/

@sloretz sloretz requested a review from hidmic June 22, 2021 23:34
@sloretz sloretz self-assigned this Jun 22, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Jun 22, 2021 •
edited
Loading

CI (build: --packages-up-to rosidl_generator_py test: --packages-select rosidl_generator_py)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows Debug Build Status

@sloretz sloretz marked this pull request as draft June 22, 2021 23:53
@sloretz sloretz removed the request for review from hidmic June 22, 2021 23:53
@sloretz
Copy link
Contributor Author

sloretz commented Jun 22, 2021

Converted to draft - it didn't solve the issue after all

@sloretz
Copy link
Contributor Author

sloretz commented Jun 23, 2021

Second attempt at Windows Debug CI, now with a debug message() statement Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Jun 23, 2021

Windows Debug CI Build Status

@sloretz sloretz force-pushed the test_cli_extension_python_d_win32 branch from 095fff6 to 47657f1 Compare June 23, 2021 16:52
@sloretz
Use python_d for test_cli_extension in Debug mode
09aac12 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz force-pushed the test_cli_extension_python_d_win32 branch from 47657f1 to 09aac12 Compare June 23, 2021 16:54
@sloretz
Copy link
Contributor Author

sloretz commented Jun 23, 2021

CI (build: --packages-up-to rosidl_generator_py test: --packages-select rosidl_generator_py)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows Debug Build Status

@sloretz sloretz marked this pull request as ready for review June 23, 2021 16:56
clalancette
clalancette approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one nit inline, but I'll approve anyway. You can decide whether to change it or not.

rosidl_generator_py/CMakeLists.txt
find_package(python_cmake_module REQUIRED)
find_package(PythonExtra MODULE REQUIRED)

set(BUILDTYPE_PYTHON_EXECUTABLE "${PYTHON_EXECUTABLE}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit, but elsewhere where we do the PYTHON_EXECUTABLE dance, we typically call the variable "PYTHON_EXECUTABLE" (see https://github.com/ros2/rclpy/blob/c67e43a69a1580eeac4a90767e24ceeea31a298e/rclpy/CMakeLists.txt#L32-L37 for an example). We may want to do the same here for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it away from _PYTHON_EXECUTABLE because the rosidl_generate_interfaces() call uses CMake code that also uses that same variable name, but slightly differently, and I didn't want to have to think about whether this was correct with that or not.

@sloretz sloretz merged commit 18f325a into master Jun 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the test_cli_extension_python_d_win32 branch June 23, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette