-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use python_d for test_cli_extension in Debug mode #136
Conversation
Converted to draft - it didn't solve the issue after all |
095fff6
to
47657f1
Compare
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
47657f1
to
09aac12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one nit inline, but I'll approve anyway. You can decide whether to change it or not.
find_package(python_cmake_module REQUIRED) | ||
find_package(PythonExtra MODULE REQUIRED) | ||
|
||
set(BUILDTYPE_PYTHON_EXECUTABLE "${PYTHON_EXECUTABLE}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nit, but elsewhere where we do the PYTHON_EXECUTABLE
dance, we typically call the variable "PYTHON_EXECUTABLE" (see https://github.com/ros2/rclpy/blob/c67e43a69a1580eeac4a90767e24ceeea31a298e/rclpy/CMakeLists.txt#L32-L37 for an example). We may want to do the same here for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it away from _PYTHON_EXECUTABLE
because the rosidl_generate_interfaces()
call uses CMake code that also uses that same variable name, but slightly differently, and I didn't want to have to think about whether this was correct with that or not.
This should fix a test failure on Windows Debug where the test fails to import
numpy
extension modules.https://ci.ros2.org/job/nightly_win_deb/2027/testReport/junit/(root)/projectroot/test_cli_extension/