Replace rosidl_cmake imports with rosidl_pycommon #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
requested review from
hidmic,
adityapande-1995,
deepanshubansal01 and
ihasdapie
ihasdapie
approved these changes
Aug 9, 2022
delete-merged-branch
bot
deleted the
jacob/deprecate_rosidl_cmake_python
branch
14 tasks
sloretz
added a commit
that referenced
this pull request
Aug 22, 2022
* Invert bounds check in order to permit floating point NaN values Signed-off-by: Øystein Sture <os@skarvtech.com> * Allow floating point numbers set to Inf to pass bounds check Signed-off-by: Øystein Sture <os@skarvtech.com> * Add float/double NaN/Inf tests Signed-off-by: Øystein Sture <os@skarvtech.com> * Increase precision of float32 bounds Signed-off-by: Øystein Sture <os@skarvtech.com> * Only perform float64 bounds check on non-compliant IEEE 754 systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Resolve failing nan/inf test by comparing the same types Signed-off-by: Øystein Sture <os@skarvtech.com> * Change decode error mode to replace (#176) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Replace rosidl_cmake imports with rosidl_pycommon (#177) Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Delete trailing whitespace Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split fail case array check tests into two Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Øystein Sture <os@skarvtech.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
pushed a commit
that referenced
this pull request
Nov 7, 2022
* Invert bounds check in order to permit floating point NaN values Signed-off-by: Øystein Sture <os@skarvtech.com> * Allow floating point numbers set to Inf to pass bounds check Signed-off-by: Øystein Sture <os@skarvtech.com> * Add float/double NaN/Inf tests Signed-off-by: Øystein Sture <os@skarvtech.com> * Increase precision of float32 bounds Signed-off-by: Øystein Sture <os@skarvtech.com> * Only perform float64 bounds check on non-compliant IEEE 754 systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Resolve failing nan/inf test by comparing the same types Signed-off-by: Øystein Sture <os@skarvtech.com> * Change decode error mode to replace (#176) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Replace rosidl_cmake imports with rosidl_pycommon (#177) Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Delete trailing whitespace Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split fail case array check tests into two Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Øystein Sture <os@skarvtech.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
added a commit
that referenced
this pull request
Nov 8, 2022
* Allow NaN values to pass floating point bounds check. (#167) * Invert bounds check in order to permit floating point NaN values Signed-off-by: Øystein Sture <os@skarvtech.com> * Allow floating point numbers set to Inf to pass bounds check Signed-off-by: Øystein Sture <os@skarvtech.com> * Add float/double NaN/Inf tests Signed-off-by: Øystein Sture <os@skarvtech.com> * Increase precision of float32 bounds Signed-off-by: Øystein Sture <os@skarvtech.com> * Only perform float64 bounds check on non-compliant IEEE 754 systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Resolve failing nan/inf test by comparing the same types Signed-off-by: Øystein Sture <os@skarvtech.com> * Change decode error mode to replace (#176) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Replace rosidl_cmake imports with rosidl_pycommon (#177) Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Delete trailing whitespace Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split fail case array check tests into two Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Øystein Sture <os@skarvtech.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> * 👨🌾 Fix NaN values bound numpy windows version (#182) * Replaced equal_nan for numpy<1.19 Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> * Remove stray numpy import (#185) NumPy was being imported in the template code (not the template output) for apparently no reason. This was causing problems when cross-compiling, where NumPy is only available for the target platform. Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Signed-off-by: Øystein Sture <os@skarvtech.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Co-authored-by: Øystein Sture <oysstu@users.noreply.github.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Co-authored-by: Ben Wolsieffer <benwolsieffer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ros2/rosidl#696