Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow NaN values to pass floating point bounds check. #167

Merged
merged 13 commits into from
Aug 22, 2022
Merged

Allow NaN values to pass floating point bounds check. #167

merged 13 commits into from
Aug 22, 2022

Commits on May 19, 2022

  1. Invert bounds check in order to permit floating point NaN values 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed May 19, 2022
    Configuration menu
    Copy the full SHA
    36cac68 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Allow floating point numbers set to Inf to pass bounds check 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    b73beef View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Add float/double NaN/Inf tests 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    4abb790 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Increase precision of float32 bounds 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    26ab69b View commit details
    Browse the repository at this point in the history

  2. Only perform float64 bounds check on non-compliant IEEE 754 systems 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    490a7fd View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Disable bounds test for float64 on IEEE 754 compatible systems 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b966bc0 View commit details
    Browse the repository at this point in the history

  2. Disable bounds test for float64 on IEEE 754 compatible systems 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    1af52bd View commit details
    Browse the repository at this point in the history

  3. Resolve failing nan/inf test by comparing the same types 

    Signed-off-by: Øystein Sture <os@skarvtech.com>
    @oysstu
    oysstu committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    fb555a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Change decode error mode to replace (#176) 

    Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    20df683 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Replace rosidl_cmake imports with rosidl_pycommon (#177) 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    5560452 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Merge branch 'oysstu/fix_bounds_check_nan' of github.com:oysstu/rosid… 

    …l_python into pr_167
    @sloretz
    sloretz committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    78fea5b View commit details
    Browse the repository at this point in the history

  2. Delete trailing whitespace 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    4ff1160 View commit details
    Browse the repository at this point in the history

  3. Split fail case array check tests into two 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    0431832 View commit details
    Browse the repository at this point in the history