Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quoted strings for new flake8-quote check. #42

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Fix quoted strings for new flake8-quote check. #42

merged 1 commit into from
Apr 19, 2019

Commits on Apr 19, 2019

  1. Fix quoted strings for new flake8-quote check. 

    Note that for generated code, we unconditionally disable the
flake8-quote check Q003 (Change outer quotes to avoid escaping
inner quotes).  For non-string types, this will have no effect.
For string types, it could be fairly expensive to scan strings
for single or double quotes.  The expense just doesn't seem
worth it and the resulting return value won't be exactly what
the user typed into their .msg file.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    031aeb0 View commit details
    Browse the repository at this point in the history