Don't override user provided compile definitions (backport #145) (#146)

* Don't override user provided compile definitions (#145) * Don't override user provided compile definitions Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
ros2 · Jun 23, 2023 · c111323 · c111323
1 parent 7789b1d
commit c111323
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake b/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake
@@ -95,8 +95,8 @@ set_target_properties(${rosidl_generate_interfaces_TARGET}${_target_suffix}
     CXX_STANDARD 14)
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  set_target_properties(${rosidl_generate_interfaces_TARGET}${_target_suffix}
-    PROPERTIES COMPILE_OPTIONS -Wall -Wextra -Wpedantic)
+  target_compile_options(${rosidl_generate_interfaces_TARGET}${_target_suffix}
+    PRIVATE -Wall -Wextra -Wpedantic)
 endif()
 
 # if only a single typesupport is used this package will directly reference it