[service introspection] Guard #include <cstddef> when being included from a c source
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
14 tasks
clalancette
requested changes
Jun 30, 2022
rosidl_typesupport_c/include/rosidl_typesupport_c/type_support_map.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
ivanpauno
approved these changes
Jul 13, 2022
clalancette
approved these changes
Jul 13, 2022
|
@ihasdapie I see this is marked as a draft, but it looks fine as is. Mind if I run CI and merge it? |
|
@sloretz Np, I've just made a CI job for it
|
|
Ignore the previous comment, needed to make a new branch for CI to avoid pulling in my changes in other repos...
|
|
@ihasdapie Be careful to use "Resolves #X" in the ticket description only when it should close the connected ticket. Merging this closed the meta-ticket tracking the service introspection work. |
|
@jacobperron Got it. I had originally planned on merging them at the same time but in retrospect that might be a bit too hopeful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prototype for the service introspection REP (ros-infrastructure/rep#360) implementing the proposed single serialized message approach (ros-infrastructure/rep#360 (comment)).
This PR wraps
#include <cstddef>inrosidl_typesupport_c/include/rosidl_typesupport_c/type_support_map.hso thatrclcan accesstype_support_map_tSee: ros2/rcl#990
For instructions on how to build and run this see the meta-ticket ros2/ros2#1285.
Resolves ros2/ros2#1285