Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed poco dependency #59

Merged
merged 10 commits into from
Apr 8, 2020
Merged

Removed poco dependency #59

merged 10 commits into from
Apr 8, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 13, 2020

As part of the effort to remove Poco dependency described in this issue ros2/ros2#867 this PR makes use of the recent changes in rcutils ros2/rcutils#215 to load, unload and get symbols from shared libraries instead of using Poco.

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Removed poco dependency
569d4e5 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Mar 13, 2020
@ahcorde ahcorde requested a review from wjwwood March 13, 2020 09:43
@ahcorde ahcorde self-assigned this Mar 13, 2020
@ahcorde ahcorde mentioned this pull request Mar 13, 2020
Closed
7 tasks
wjwwood
wjwwood requested changes Mar 13, 2020
View reviewed changes
rosidl_typesupport_c/CMakeLists.txt Outdated Show resolved Hide resolved
rosidl_typesupport_c/src/type_support_dispatch.hpp Outdated Show resolved Hide resolved
rosidl_typesupport_c/src/type_support_dispatch.hpp Outdated Show resolved Hide resolved
rosidl_typesupport_c/src/type_support_dispatch.hpp Outdated Show resolved Hide resolved
rosidl_typesupport_c/src/type_support_dispatch.hpp Outdated Show resolved Hide resolved
rosidl_typesupport_cpp/src/type_support_dispatch.hpp Outdated Show resolved Hide resolved
@ahcorde
Included feedback: throwing errors and deallocate memory
611823d 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Removed unnecessary line in CMakeLists.txt
006336f 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Used new and delete
57ea7c8 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Replace rcutils for rcpputils
2d4f54d 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
catch bad alloc exception
fe794b8 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
reverted unrelated whitespace change
1fbe57c 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 2, 2020

rcpputils PR is merged, can you review this ? @wjwwood or @dirk-thomas

@ahcorde
Restored original error messages
e13ef1d 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fixed exceptions
39114d2 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fixed exceptions
30fe13f 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 3, 2020 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 8, 2020

Warning on Windows appears on spdlog_vendor which is strange because the code has not been modified for 15 days

14:24:43   CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.17/Modules/GNUInstallDirs.cmake:225 (message):
14:24:43     Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
14:24:43     target architecture is known.  Please enable at least one language before
14:24:43     including GNUInstallDirs.
14:24:43   Call Stack (most recent call first):
14:24:43     CMakeLists.txt:9 (include)
14:24:43   This warning is for project developers.  Use -Wno-dev to suppress it.

@ahcorde ahcorde merged commit fa96151 into master Apr 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/feature/removed_poco branch April 8, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @wjwwood @dirk-thomas