Ensure typesupport handle functions do not throw. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
CI up to
|
|
For |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Good idea! See c27aeb7. |
brawner
approved these changes
Dec 14, 2020
|
Alright! CI is happy, reviewer is happy, I'm happy. Merging. |
clalancette
added a commit
that referenced
this pull request
Dec 15, 2020
This reverts commit e513ffb.
This was referenced Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #98, I stumbled upon this inconsistency in error handling within typesupport handle functions.
These functions are eventually called by
rmwimplementations with no consideration for potential exceptions. If we add that no API documentation mentions exceptions and that some of these APIs even have C linkage, I'm inclined to assume these functions shouldn't ever throw to begin with.