Set hints to find the python version we actually want. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
mjcarroll
approved these changes
Feb 26, 2024
rosidl_typesupport_fastrtps_c/cmake/rosidl_typesupport_fastrtps_c_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
rosidl_typesupport_fastrtps_cpp/cmake/rosidl_typesupport_fastrtps_cpp_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
Thanks! You are totally right on that; accepted your suggestion. I'm going to let the Rpr job run on this, and merge assuming that comes back green. |
delete-merged-branch
bot
deleted the
clalancette/remove-python-cmake-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the commit explains the reasoning behind it.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.