don't generate IDL files and remove unused code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New round of CI with the dependency removed:
|
mikaelarguedas
added
in review
|
Merging this as it doesnt look like it's used and has been approved. |
dirk-thomas
reviewed
Aug 15, 2018
| get_filename_component(_name "${_idl_file}" NAME_WE) | ||
| set(_abs_idl_file "${${_pkg_name}_DIR}/../${_parent_folder}/dds_fastrtps/${_name}_.idl") | ||
| normalize_path(_abs_idl_file "${_abs_idl_file}") | ||
| list(APPEND _dependency_files "${_abs_idl_file}") |
There was a problem hiding this comment.
The removal of this line change breaks the automatic regeneration of the FastRTPS typesupport files when a dependent message file is changed. A following build doesn't re-build the generated code which leaves the library with outdated content.
There is another bug in the CMake which also doesn't re-expand the templates when message files in the processed package fail. I am not sure if that was working before this patch though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes what I think is a leftover from copying an existing typesupport that rely on the generation of IDL files and invocation of third party generators.
@MiguelCompany Would you mind having a look and letting us know if this code is necessary ?
First attempt at CI: