-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrench accepth nan values fix #1141
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde Unfortunately I am not able to build your branch on my ros2 iron setup. I guess something about the
But the change in the code looks reasonable to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with green CI, I'll try to build this locally.
Did you install |
I have the corresponding |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 82385de)
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 82385de)
Related with this issue #1139