Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrench accepth nan values fix #1141

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Wrench accepth nan values fix #1141

merged 1 commit into from
Feb 23, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 16, 2024

Related with this issue #1139

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@firesurfer
Copy link

firesurfer commented Feb 20, 2024

@ahcorde Unfortunately I am not able to build your branch on my ros2 iron setup.

I guess something about the ignition_math6_vendor changed between iron and rolling

Starting >>> rviz_default_plugins
--- stderr: rviz_default_plugins                            
CMake Error at CMakeLists.txt:64 (find_package):
  By not providing "Findignition_math6_vendor.cmake" in CMAKE_MODULE_PATH
  this project has asked CMake to find a package configuration file provided
  by "ignition_math6_vendor", but CMake did not find one.

  Could not find a package configuration file provided by
  "ignition_math6_vendor" with any of the following names:

    ignition_math6_vendorConfig.cmake
    ignition_math6_vendor-config.cmake

  Add the installation prefix of "ignition_math6_vendor" to CMAKE_PREFIX_PATH
  or set "ignition_math6_vendor_DIR" to a directory containing one of the
  above files.  If "ignition_math6_vendor" provides a separate development
  package or SDK, be sure it has been installed.

But the change in the code looks reasonable to me.

Copy link

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI, I'll try to build this locally.

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 20, 2024

@ahcorde Unfortunately I am not able to build your branch on my ros2 iron setup.

I guess something about the ignition_math6_vendor changed between iron and rolling

Starting >>> rviz_default_plugins
--- stderr: rviz_default_plugins                            
CMake Error at CMakeLists.txt:64 (find_package):
  By not providing "Findignition_math6_vendor.cmake" in CMAKE_MODULE_PATH
  this project has asked CMake to find a package configuration file provided
  by "ignition_math6_vendor", but CMake did not find one.

  Could not find a package configuration file provided by
  "ignition_math6_vendor" with any of the following names:

    ignition_math6_vendorConfig.cmake
    ignition_math6_vendor-config.cmake

  Add the installation prefix of "ignition_math6_vendor" to CMAKE_PREFIX_PATH
  or set "ignition_math6_vendor_DIR" to a directory containing one of the
  above files.  If "ignition_math6_vendor" provides a separate development
  package or SDK, be sure it has been installed.

But the change in the code looks reasonable to me.

Did you install sudo apt-get install ros-rolling-ignition-math6-vendor ?

@firesurfer
Copy link

I have the corresponding iron package installed as our whole code base is built against iron.

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 82385de into rolling Feb 23, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/wrench_nans branch February 23, 2024 15:42
ahcorde added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 26, 2024

https://github.com/Mergifyio backport humble iron

Copy link

mergify bot commented Feb 26, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 82385de)
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 82385de)
ahcorde added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 82385de)

Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
ahcorde added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 82385de)

Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants