-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select QoS reliability policy in DepthCloud Plugin #1159
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@@ -370,6 +404,7 @@ void DepthCloudDisplay::subscribe() | |||
std::bind(&DepthCloudDisplay::processDepthMessage, this, std::placeholders::_1)); | |||
} | |||
} | |||
subscription_start_time_ = rviz_ros_node_->get_raw_node()->now(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not using / exposing this variable anywhere else ? Could be removed otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new PR to fix the crash #1161
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit a76cf91)
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit a76cf91)
Select QoS reliability policy in DepthCloud Plugin