Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TinyXML is no longer maintained (see e.g. https://sourceforge.net/projects/tinyxml/).
Since RViz does not expose any API using TinyXML, there is nothing stopping us from upgrading.
This PR accomplishes the upgrade:
rviz_common
. To ensure that everything still works as intended, I wrote unit tests for thedisplay_factory
in advance.rviz_default_plugins
. It was only used in the robot display to pass the xml file to the urdf parser, which also offers an interface to pass the string instead.display_factory
for readability (last commit). I can easily omit the commit if this is deemed too much for now.