Upgrade to tinyxml2 for rviz #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin-Idel
force-pushed
the
cleanup/remove_tinyxml
branch
from
5dbe623
to
0bc39be
Compare
It was only used to parse a string for urdf parsing. The API however already supports passing in the string.
clalancette
force-pushed
the
cleanup/remove_tinyxml
branch
from
0bc39be
to
d48f6da
Compare
|
Just FYI, I've rebased this onto the latest. The code generally seems fine; I'll do another quick pass at reviewing, then run CI on it. |
- This will be upgraded to tinyxml2 - Make sure that it works correctly
clalancette
force-pushed
the
cleanup/remove_tinyxml
branch
from
d48f6da
to
ed8c61f
Compare
|
CI:
|
clalancette
approved these changes
Sep 3, 2020
|
Build is passing, looking good to me. I'm going to go ahead and merge this, thanks @Martin-Idel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TinyXML is no longer maintained (see e.g. https://sourceforge.net/projects/tinyxml/).
Since RViz does not expose any API using TinyXML, there is nothing stopping us from upgrading.
This PR accomplishes the upgrade:
rviz_common. To ensure that everything still works as intended, I wrote unit tests for thedisplay_factoryin advance.rviz_default_plugins. It was only used in the robot display to pass the xml file to the urdf parser, which also offers an interface to pass the string instead.display_factoryfor readability (last commit). I can easily omit the commit if this is deemed too much for now.