Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set clock type if Marker frame_locked is true #482

Merged
merged 1 commit into from Dec 3, 2019
Merged

Set clock type if Marker frame_locked is true #482

merged 1 commit into from Dec 3, 2019

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Nov 26, 2019 •
edited

Fixes #479

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Set clock type if Marker frame_locked is true
319b397 
Fixes #479

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Nov 26, 2019
@jacobperron jacobperron added the in review Waiting for review (Kanban column) label Nov 26, 2019
wjwwood
wjwwood approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit a639504 into ros2 Dec 3, 2019
@wuffle-ros wuffle-ros bot removed the in review Waiting for review (Kanban column) label Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix479 branch December 3, 2019 07:10
@mjcarroll mjcarroll added this to Proposed in Eloquent Patch Release 2 Mar 18, 2020
jdlangs added a commit to jdlangs/rviz-ros2 that referenced this pull request May 29, 2020
@jdlangs
Fix crash about comparing different time sources
c6a12c0 
This is the same fix as github.com/ros2/pull/482 which has not yet
been backported to eloquent
jacobperron added a commit that referenced this pull request Jul 20, 2020
@jacobperron
Set clock type if Marker frame_locked is true (#482)
e6b54f2 
Fixes #479

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Jul 20, 2020
Merged
@jacobperron jacobperron removed this from Proposed in Eloquent Patch Release 2 Jul 20, 2020
jacobperron added a commit that referenced this pull request Jul 20, 2020
@jacobperron
Set clock type if Marker frame_locked is true (#482)
2bf8e06 
Fixes #479

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Jul 20, 2020
Merged
jacobperron added a commit that referenced this pull request Oct 26, 2020
@jacobperron
Set clock type if Marker frame_locked is true (#482) (#583)
fc97a88 
Fixes #479

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Oct 27, 2020
@jacobperron
Set clock type if Marker frame_locked is true (#482) (#580)
9b6bfc5 
Fixes #479

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rviz crashes when using Marker with frame_locked = True
2 participants
@jacobperron @wjwwood