Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX interface link libraries in ogre vendor #761

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

laszloturanyi
Copy link
Contributor

FIX to error:
rviz_ogre_vendor-extras.cmake:130 (set_target_properties): Property INTERFACE_LINK_LIBRARIES may not contain link-type keyword "optimized".

@clalancette
Copy link
Contributor

Can you give a bit more context on how you saw this error? We aren't seeing it in CI, but we aren't testing all possible combinations. Thanks.

@clalancette clalancette added the more-information-needed Further information is required label Oct 14, 2021
@Ace314159
Copy link
Contributor

I have also encountered this error when using vcpkg to provide the dependencies. It tries to specify different library paths for debug and release. When it does so, ${_extra_interface_link_libraries} looks something like this: optimized;path/to/optimized/lib;debug;path/to/debug/lib;.... set_target_properties doesn't properly handle this, but target_link_libraries does.

@laszloturanyi
Copy link
Contributor Author

Hi,
We met this error when building ros2 galactic from source in jenkins, As I remember it had to do something with building in release or debug (and postfixes).

@jacobperron
Copy link
Member

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit a7e3ceb into ros2:ros2 Mar 28, 2022
@Ace314159
Copy link
Contributor

@jacobperron Can this be backported to foxy?

@jacobperron jacobperron removed the more-information-needed Further information is required label Apr 1, 2022
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 8 via automation Apr 1, 2022
@jacobperron
Copy link
Member

I've added this to project boards for tracking backports to Foxy and Galactic.

jacobperron pushed a commit that referenced this pull request Jul 22, 2022
Co-authored-by: Laszlo Turanyi <laszlo.turanyi@faulhornlabs.com>
jacobperron pushed a commit that referenced this pull request Jul 22, 2022
Co-authored-by: Laszlo Turanyi <laszlo.turanyi@faulhornlabs.com>
@jacobperron jacobperron removed this from Proposed in Galactic Patch Release 2 Jul 22, 2022
@jacobperron jacobperron removed this from Proposed in Foxy Patch Release 8 Jul 22, 2022
@jacobperron
Copy link
Member

Backports open,

#879
#880

jacobperron added a commit that referenced this pull request Sep 12, 2022
Co-authored-by: Laszlo Turanyi <laszlo.turanyi@faulhornlabs.com>

Co-authored-by: Laszlo Turanyi <58770032+laszloturanyi@users.noreply.github.com>
Co-authored-by: Laszlo Turanyi <laszlo.turanyi@faulhornlabs.com>
cottsay pushed a commit that referenced this pull request Dec 3, 2022
Co-authored-by: Laszlo Turanyi <58770032+laszloturanyi@users.noreply.github.com>
Co-authored-by: Laszlo Turanyi <laszlo.turanyi@faulhornlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants