Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate marker display #229

Merged
merged 29 commits into from
Mar 17, 2018
Merged

Migrate marker display #229

merged 29 commits into from
Mar 17, 2018

Commits on Mar 12, 2018

  1. Move marker_display

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    1737996 View commit details
    Browse the repository at this point in the history

  2. Make Markers compile and lint

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    d6246e2 View commit details
    Browse the repository at this point in the history

  3. Make MarkerDisplay compile and work 

    - Fix QueueSizeProperty in MarkerDisplay
- Fix MarkerArray subscription
    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    6cfb89e View commit details
    Browse the repository at this point in the history

  4. Add MarkerDisplay to plugin_description.xml

    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    f4cf7a3 View commit details
    Browse the repository at this point in the history

  5. Extract interface from frame_manager to make it mockable.

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    0e88c8e View commit details
    Browse the repository at this point in the history

  6. Move frame_manager.hpp from include to src.

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    f79e886 View commit details
    Browse the repository at this point in the history

  7. Create mock class for FrameManager

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    2327c5f View commit details
    Browse the repository at this point in the history

  8. Don't render markers when transform is missing

    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    1e962df View commit details
    Browse the repository at this point in the history

  9. Reorder cleanup to prevent segmentation faults 

    Delete render_panel after visualization manager since the display cleanup in the visualization manager requires an existing render_panel
    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    4cacbd7 View commit details
    Browse the repository at this point in the history

  10. Setup marker tests

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    4219f2f View commit details
    Browse the repository at this point in the history

  11. Refactoring of ArrowMarker

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    3d52cb3 View commit details
    Browse the repository at this point in the history

  12. Split triangle list marker into multiple methods

    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    52d5fa7 View commit details
    Browse the repository at this point in the history

  13. Refactor (minor) marker_base

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    c1fc8b6 View commit details
    Browse the repository at this point in the history

  14. Extract common functionality from line_markers and refactoring

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    64266ab View commit details
    Browse the repository at this point in the history

  15. Refactor ShapeMarker

    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    ba0dd9a View commit details
    Browse the repository at this point in the history

  16. Minor refactoring of text_view_facing_marker

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    2c5349e View commit details
    Browse the repository at this point in the history

  17. Refactoring of PointsMarker

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    c598ef6 View commit details
    Browse the repository at this point in the history

  18. Fix test in mesh_resource_marker

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    dfd27df View commit details
    Browse the repository at this point in the history

  19. Refactoring of mesh_resource_marker

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    2686a26 View commit details
    Browse the repository at this point in the history

  20. Remove duplicate code

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    e4a0dab View commit details
    Browse the repository at this point in the history

  21. Expose constructor necessary for testing MarkerDisplay

    @anhosi @Martin-Idel-SI
    anhosi authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    3f68cb5 View commit details
    Browse the repository at this point in the history

  22. Add tests for MarkerDisplay

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    adfacef View commit details
    Browse the repository at this point in the history

  23. Refactor MarkerDisplay

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    004af34 View commit details
    Browse the repository at this point in the history

  24. Extract error printing in triangle list marker

    @greimela-si @Martin-Idel-SI
    greimela-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    2f7f087 View commit details
    Browse the repository at this point in the history

  25. Refactoring of tests to only use one test target

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    af98882 View commit details
    Browse the repository at this point in the history

  26. Reset position of arrow to 0, if previously was set from points

    @botteroa-si @Martin-Idel-SI
    botteroa-si authored and Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    cafe2de View commit details
    Browse the repository at this point in the history

  27. Disable tests for now

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    0254e9f View commit details
    Browse the repository at this point in the history

  28. Fix FrameManager include in PoseDisplay

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    e30505e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Add visualization_msgs to package.xml

    @Martin-Idel-SI
    Martin-Idel-SI committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    a7347ac View commit details
    Browse the repository at this point in the history