Add virtual destructors for WindowManagerInterface and ViewportProjectionFinder #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Oct 5, 2018
|
CI:
|
|
Oh, right. CI is going to fail because this branch needs to be rebased after ros2/rcutils#113 was merged. @kartikmohta , would you mind doing a quick rebase? Thanks. |
…tionFinder To fix the following warnings (converted to errors by compile options): error: destructor called on non-final 'MockProjectionFinder' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] error: destructor called on non-final 'MockWindowManagerInterface' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
|
@clalancette Rebased to be on top of the current |
|
CI is happy, we need this to compile (along with ros2/rclcpp#566), so I'm going to merge. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the following warnings (converted to errors by compile options):
This is when compiling with clang 7 on ArchLinux.