Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make libraries to avoid compiling files multiple times #774

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Make libraries to avoid compiling files multiple times #774

merged 1 commit into from
Sep 27, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 24, 2021

I noticed some packages are compiling files multiple times - usually test files. This PR makes libraries for the pointcloud_messages.cpp and point_cloud_common_page_object.cpp files because the are compiled 8 times each.

@sloretz
Make libraries to avoid compiling files multiple times
dcad072 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Sep 24, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Sep 24, 2021

CI (build: --packages-up-to rviz_default_plugins test: --packages-select rviz_default_plugins)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@sloretz sloretz mentioned this pull request Sep 24, 2021
Open
@sloretz sloretz merged commit eb2b4e8 into ros2 Sep 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the rviz_duplicate_compilation branch September 27, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette