Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF2 buffer cache time option #780

Closed
wants to merge 5 commits into from
Closed

TF2 buffer cache time option #780

wants to merge 5 commits into from

Conversation

gonzodepedro
Copy link
Contributor

Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar

Added tf2 buffer cache time option
26c9ecb 
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
ahcorde
ahcorde requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters are failing

@jacobperron jacobperron mentioned this pull request Oct 15, 2021
Open
@ivanpauno
please linters
0b3305d 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Make it work
9887ad5 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Rename buffer_cache_sec to buffer_cache_duration, as var type is std:…
dd1c41d 
…:chrono::nanoseconds

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Ignore unused argument
828ee46 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno self-assigned this Oct 20, 2021
@ivanpauno ivanpauno added the enhancement New feature or request label Oct 20, 2021
jacobperron
jacobperron reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fairly invasive change for a CLI option; it touches API in a lot of places.

What if we declared a read-only parameter on the node after parsing the argument, and then the TFWrapper can access the value through the node instead?

@ivanpauno ivanpauno mentioned this pull request Nov 3, 2021
Merged
@ivanpauno
Copy link
Member

Agreed, see #792

@ivanpauno
Copy link
Member

Replaced with #792

@ivanpauno ivanpauno closed this Nov 3, 2021
@jacobperron jacobperron deleted the gonzodepedro/tf-buffer-time-config branch November 3, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron left review comments

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gonzodepedro @ivanpauno @jacobperron @ahcorde