Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[galactic] Export Qt5 dependencies properly (#687) #789

Merged
merged 1 commit into from Nov 8, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 29, 2021

This pull request backports #687 to Galactic.

Galactic CI above rviz_default_plugins and rviz_rendering:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

* Export Qt5 as rviz_default_plugins dependency properly
* Export Qt5 as rviz_rendering dependency properly

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Does it make sense to backport this to Foxy as well?

@hidmic
Copy link
Contributor Author

hidmic commented Nov 8, 2021

Does it make sense to backport this to Foxy as well?

Sounds reasonable to me.

@hidmic hidmic merged commit 11a5a26 into galactic Nov 8, 2021
@hidmic hidmic deleted the hidmic/galactic/backport-687 branch November 8, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants