Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify access specifier to protected or public for the scope of processMessage() member function #983

Closed
wants to merge 1 commit into from
Closed

Modify access specifier to protected or public for the scope of processMessage() member function #983

wants to merge 1 commit into from

Conversation

hyunseok-yang
Copy link
Contributor

  • pose_display, pose_with_covariance_display and relative_humidity_display

@hyunseok-yang
Copy link
Contributor Author

hello, anybody know why this message occured?
Category 'whitespace/end_of_line' errors found: 1

@hyunseok-yang
Modify access specifier to protected or public for the scope of proce…
51cbd25 
…ssMessage() member function

- pose_display, pose_with_covariance_display and relative_humidity_display

Signed-off-by: (=YG=) Hyunseok Yang <hyunseok7.yang@lge.com>
@hyunseok-yang hyunseok-yang force-pushed the modify/humble/displays/class/access-specifier branch from 13ec978 to 51cbd25 Compare May 11, 2023 06:37
@hyunseok-yang
Copy link
Contributor Author

hello, anybody know why this message occured? Category 'whitespace/end_of_line' errors found: 1

I guess I found by myself. there was empty whitespace on the empty line :)

@hyunseok-yang hyunseok-yang mentioned this pull request May 11, 2023
Closed
@Yadunund
Copy link
Member

Could you retarget this PR to rolling? Our practice is to merge any new changes into rolling branch first which we will then backport to other distro branches if the changes do not break API/ABI.

@hyunseok-yang
Copy link
Contributor Author

Ok sure!

@hyunseok-yang hyunseok-yang changed the base branch from humble to rolling May 12, 2023 02:37
@hyunseok-yang
Copy link
Contributor Author

hyunseok-yang commented May 12, 2023 •
edited
Loading

Could you retarget this PR to rolling? Our practice is to merge any new changes into rolling branch first which we will then backport to other distro branches if the changes do not break API/ABI.

@Yadunund

I created another separated branch for rolling and make PR.
#984

@hyunseok-yang hyunseok-yang changed the base branch from rolling to humble May 12, 2023 04:02
@clalancette
Copy link
Contributor

Given that we have #984 now, I'm going to close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyunseok-yang @Yadunund @clalancette