Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed spdlog_vendor warnings #36

Merged
merged 3 commits into from Apr 26, 2024
Merged

Removed spdlog_vendor warnings #36

merged 3 commits into from Apr 26, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 25, 2024

There is a warning on spdlog_vendor https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1868/consoleText

The PR should fix the issue

@ahcorde
Removed spdlog_vendor warnings
3c2544b 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 25, 2024
cottsay
cottsay reviewed Apr 25, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@ahcorde
feedback
60a6ecd 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from cottsay April 25, 2024 16:16
clalancette
clalancette approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI (and let's also run CI on RHEL to be sure).

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 25, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • RHEL Build Status

@ahcorde
Fixed windows build
a11f410 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 25, 2024 •
edited

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • RHEL Build Status

@ahcorde ahcorde merged commit 4510d9a into rolling Apr 26, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/spdlog_Warning branch April 26, 2024 09:56
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 26, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Apr 26, 2024 •
edited

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 26, 2024
@ahcorde @mergify
Removed spdlog_vendor warnings (#36)
288b32a 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 4510d9a)
@mergify mergify bot mentioned this pull request Apr 26, 2024
Merged
ahcorde added a commit that referenced this pull request Apr 26, 2024
@mergify @ahcorde
Removed spdlog_vendor warnings (#36) (#37)
7d3a3e7 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 4510d9a)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@cottsay cottsay cottsay approved these changes

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @clalancette @cottsay