Add mypy tests to check static typing #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the newly-added ament_mypy package. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
ruffsl
reviewed
Aug 9, 2019
| @pytest.mark.mypy | ||
| @pytest.mark.linter | ||
| def test_mypy(): | ||
| assert main(argv=[]) == 0, 'Found errors' |
There was a problem hiding this comment.
How does this innovation work?
Does it just test all source .py files in the parent package the test file is located under?
There was a problem hiding this comment.
Yes, at this point it will be the .py files in this package only. We went back and forth on the PR setting the MYPYPATH in different ways, but ended up shipping the simplest thing that worked while we continue discussing how that should be done.
jacobperron
reviewed
Aug 19, 2019
| extra_files.extend(package_files('sros2/policy/schemas')) | ||
| extra_files.extend(package_files('sros2/policy/templates')) | ||
|
|
||
| extra_files = ( |
There was a problem hiding this comment.
Is this change relevant, and if so how?
There was a problem hiding this comment.
It allows mypy to determine the type without us needing to add it manually.
Edit: re-triggered now that ament/ament_lint#182 is merged |
|
Thanks for the addition! |
jacobperron
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the newly-added ament_mypy package.