Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy tests to check static typing #154

Merged
merged 1 commit into from Aug 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion sros2/package.xml
Expand Up @@ -18,11 +18,12 @@

<test_depend>ament_copyright</test_depend>
<test_depend>ament_flake8</test_depend>
<test_depend>ament_mypy</test_depend>
<test_depend>ament_pep257</test_depend>
<test_depend>python3-pytest</test_depend>
<test_depend>std_msgs</test_depend>
<test_depend>std_srvs</test_depend>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down
10 changes: 5 additions & 5 deletions sros2/setup.py
Expand Up @@ -12,11 +12,11 @@ def package_files(directory):
return paths


extra_files = []
extra_files.extend(package_files('sros2/policy/defaults'))
extra_files.extend(package_files('sros2/policy/schemas'))
extra_files.extend(package_files('sros2/policy/templates'))

extra_files = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change relevant, and if so how?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows mypy to determine the type without us needing to add it manually.

package_files('sros2/policy/defaults') +
package_files('sros2/policy/schemas') +
package_files('sros2/policy/templates')
)

setup(
name='sros2',
Expand Down
22 changes: 22 additions & 0 deletions sros2/test/test_mypy.py
@@ -0,0 +1,22 @@
# Copyright 2019 Canonical Ltd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from ament_mypy.main import main
import pytest


@pytest.mark.mypy
@pytest.mark.linter
def test_mypy():
assert main(argv=[]) == 0, 'Found errors'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this innovation work?
Does it just test all source .py files in the parent package the test file is located under?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, at this point it will be the .py files in this package only. We went back and forth on the PR setting the MYPYPATH in different ways, but ended up shipping the simplest thing that worked while we continue discussing how that should be done.