[FIX] remove dangerous mutable default arguments in generate_artifacts #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You cannot safely use = [] as a default argument in Python; subsequent calls will reuse that object. It probably doesn't matter in this case, as these are all "read-only" arguments, but it is better not to do it at all. Instead, we recognize that this function is always called with all of its arguments, so there is no need for default arguments at all. While in here, I noticed that, generate_artifacts was returning a boolean on an error path, which is not allowed by its signature. So fix that as well. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rolling #318 +/- ##
========================================
Coverage 88.92% 88.92%
========================================
Files 24 24
Lines 614 614
Branches 64 64
========================================
Hits 546 546
Misses 50 50
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
CI:
|
mikaelarguedas
approved these changes
May 24, 2024
mikaelarguedas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot safely use = [] as a default argument in Python; subsequent calls will reuse that object. It probably doesn't matter in this case, as these are all "read-only" arguments, but it is better not to do it at all. Instead, we recognize that this function is always called with all of its arguments, so there is no need for default arguments at all.
While in here, I noticed that, generate_artifacts was returning a boolean on an error path, which is not allowed by its signature. So fix that as well.