Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate loading of Identity and Permission Certificate Authorities #66

Closed
wants to merge 1 commit into from

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Aug 30, 2018

Related: #43
Includes minimal changes to support the use of loading separate Identity and Permission Certificate Authorities for DDS security. For simplicity the common CA is merely renamed as two different files expected in the security root path.

@mikaelarguedas
Copy link
Member

Thanks @ruffsl !

These branches were either very out of date (in the case of the sros2 repository) or fell behind master since the PRs were opened. In the future I recommend you to rebase the branches on the latest master before opening PRs, as well as set the PRs' labels as "in review" to get reviews in a timely manner (as you are a member of the ros2 organization, your PRs get labeled as "in progress" automatically).

I opened a set of rebased PRs (#67 and connected PRs) to test this change.

@codebot FYI

@ruffsl
Copy link
Member Author

ruffsl commented Sep 10, 2018

rebased version #67 merged

@ruffsl ruffsl closed this Sep 10, 2018
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants