Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug python executable on windows #281

Merged
merged 2 commits into from Jun 14, 2018
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jun 12, 2018

Copies the logic from test_communication to use the debug python executable on windows when appropriate.

CI just windows debug Build Status

context

@sloretz sloretz added bug Something isn't working in progress Actively being worked on (Kanban column) labels Jun 12, 2018
@sloretz sloretz self-assigned this Jun 12, 2018
dirk-thomas
dirk-thomas previously approved these changes Jun 12, 2018
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (assuming CI is happy 😉)

mikaelarguedas
mikaelarguedas previously approved these changes Jun 12, 2018
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with green CI

@mikaelarguedas
Copy link
Member

CI testing test_cli and test_cli_remapping (with a3aea36):

None: Build Status
Debug: Build Status

Placing this in review

Launching another debug CI testing test_communication as well to be sure nothing broke along the way
Build Status

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 14, 2018
@mikaelarguedas mikaelarguedas dismissed dirk-thomas’s stale review June 14, 2018 22:35

new commits changing the approach

@mikaelarguedas mikaelarguedas dismissed their stale review June 14, 2018 22:35

things have changed

Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas mikaelarguedas merged commit d76717b into master Jun 14, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jun 14, 2018
@mikaelarguedas mikaelarguedas deleted the python_debug_windows branch June 14, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants