Use test fixtures to create SROS artifacts #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation creates SROS artifacts during the configure phase. This is undesirable for at least a variety of reasons, such as: * The ros2 binary is invoked during build, meaning that a regression in that tool will break the entire CI build instead of appearing as a test failure. * Some of the environment is captured during the artifact generation and it may not be the same when the tests are invoked. Namely, changes to ROS_DOMAIN_ID between build and test will break. The test fixtures work similarly to tests themselves, and are automatically run if any tests requiring them are enabled. If the fixture fails, the dependent tests are not attempted. Signed-off-by: Scott K Logan <logans@cottsay.net>
Prototype build with this change and parallelized tests: |
cottsay
commented
Aug 7, 2023
clalancette
reviewed
Aug 7, 2023
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
cottsay/test-fixtures
branch
from
15719f8
to
6d2fde8
Compare
|
Fresh CI:
|
clalancette
approved these changes
Aug 7, 2023
|
Thanks for the review. In order to really leverage this on ci.ros2.org, we'll probably want to backport it to Iron and Humble. CMake 3.7 is an acceptable limitation for both of those platforms from what I can tell, and this shouldn't have any affect on payload. Do you see any reason not to backport? |
No, I think that is totally fine. |
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
The current implementation creates SROS artifacts during the configure phase. This is undesirable for a variety of reasons, such as: * The ros2 binary is invoked during build, meaning that a regression in that tool will break the entire CI build instead of appearing as a test failure. * Some of the environment is captured during the artifact generation and it may not be the same when the tests are invoked. Namely, changes to ROS_DOMAIN_ID between build and test will break. The test fixtures work similarly to tests themselves, and are automatically run if any tests requiring them are enabled. If the fixture fails, the dependent tests are not attempted. (cherry picked from commit d98fcb9)
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
The current implementation creates SROS artifacts during the configure phase. This is undesirable for a variety of reasons, such as: * The ros2 binary is invoked during build, meaning that a regression in that tool will break the entire CI build instead of appearing as a test failure. * Some of the environment is captured during the artifact generation and it may not be the same when the tests are invoked. Namely, changes to ROS_DOMAIN_ID between build and test will break. The test fixtures work similarly to tests themselves, and are automatically run if any tests requiring them are enabled. If the fixture fails, the dependent tests are not attempted. (cherry picked from commit d98fcb9)
|
@cottsay It looks like this may have lead to a regression in the nightly repeated jobs: https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_repeated/2468/testReport/(root)/projectroot/remove_missing_key/ . Can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation creates SROS artifacts during the configure phase. This is undesirable for a variety of reasons, such as:
The test fixtures work similarly to tests themselves, and are automatically run if any tests requiring them are enabled. If the fixture fails, the dependent tests are not attempted.