Add in a test for the new get_parameter_or_set_default API. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
added
in review
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
reviewed
Sep 12, 2018
| { | ||
| // try to get with default a parameter that is already set | ||
| int64_t foo_value = -1; | ||
| node->get_parameter_or("foo", foo_value, static_cast<int64_t>(42)); |
There was a problem hiding this comment.
Is this supposed to be a call to get_parameter_or_set_default()?
There was a problem hiding this comment.
Yes, absolutely, thanks for pointing it out. Cut-n-paste error. It should be fixed now.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
get-parameter-or-set-default
branch
from
9d44bf4
to
4f19390
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Sep 13, 2018
sloretz
approved these changes
Sep 13, 2018
|
Thanks for the review, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged if ros2/rclcpp#551 is approved and merged.
connects to ros2/rclcpp#551