Disable Fast-RTPS security tests until they work with OpenSSL 1.1.1{d,e,f} #413
Conversation
|
CI:
|
|
To clarify these same tests are failing on macOS as well where OpenSSL 1.1.1f is being used and we've been holding our Windows builds on the previous 1.0.2 release channel for OpenSSL as well. I think the PR title might be worth changing since this is a cross-platform issue. |
|
Edit: scratch this. What nuclearsandwich said |
clalancette
changed the title
clalancette
changed the title
eProsima/Fast-DDS#1087 is the issue that needs to be resolved. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
disable-fastrtps-security-tests
branch
from
517d2da
to
a7157e5
Compare
I updated both the title of the ticket and the comment in the commit to reflect that. |
|
The warnings on Linux, Linux aarch64, and macOS come from tracetools, so nothing to do with this change. One of the CMake warnings on Windows is the same tracetools warning; the other seems to be spurious, so ignoring that one. The test failures are all around rmw_connext_cpp; while I don't see those in any of the Windows nightlies, I'm having a hard time seeing how this PR would cause them. @nuclearsandwich Thoughts on merging this one as-is? |
|
I was checking with @cottsay offline as this Windows is the one place I expect the security tests with connext to pass right now (see #409 and ros2/ci#421) I've started a vanilla master job replicating the Windows CI to verify that those tests fail without this change but I say let's merge this now and I'll revert this PR if it is somehow causing the failures. |
|
The connext failures are present with master so that's a go-ahead from me. |
)" This reverts commit 047f7fa.
|
Please create a follow up ticket to reenable the tests. |
|
Please create a follow up ticket to reenable the tests. It was already done. #415 |
)" This reverts commit 047f7fa.
eProsima/Fast-DDS#1087 is the
issue that needs to be resolved.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org