Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show command to change topic name on readme #27

Merged
merged 2 commits into from Oct 31, 2023
Merged

Show command to change topic name on readme #27

merged 2 commits into from Oct 31, 2023

Conversation

asukiaaa
Copy link

I want to you to show command to change topic name like teleop_twist_keyboard of ros1.
https://github.com/ros-teleop/teleop_twist_keyboard

Thank you.

clalancette
clalancette requested changes Oct 30, 2023
View reviewed changes
README.md Outdated
@@ -3,7 +3,15 @@ Generic Keyboard Teleoperation for ROS

## Launch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Launch
## Run

README.md Outdated
@@ -3,7 +3,15 @@ Generic Keyboard Teleoperation for ROS

## Launch

To run: `ros2 run teleop_twist_keyboard teleop_twist_keyboard`
Run.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run.

README.md Outdated
ros2 run teleop_twist_keyboard teleop_twist_keyboard
```

Publishing to a different topic (in this case my_cmd_vel).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Publishing to a different topic (in this case my_cmd_vel).
Publishing to a different topic (in this case `my_cmd_vel`).

@asukiaaa
Copy link
Author

asukiaaa commented Oct 30, 2023 •
edited

Thank you for the feedback.
I updated so.

clalancette
clalancette approved these changes Oct 31, 2023
View reviewed changes
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@clalancette clalancette merged commit d78ed3b into ros2:dashing Oct 31, 2023
3 of 4 checks passed
@asukiaaa asukiaaa deleted the feature/show-command-to-change-topic-name branch October 31, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asukiaaa @clalancette