Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arrays.srv #7

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Add Arrays.srv #7

merged 1 commit into from
Jul 20, 2019

Conversation

jacobperron
Copy link
Member

This acts as a regression test for building services with the same name and array type in the request and response.

See ros2/rosidl#386

Connects to ros2/rosidl#387

@jacobperron
Add Arrays.srv
aa006fc 
This acts as a regression test for building services with the same name and array type in the request and response.

See ros2/rosidl#386

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status

As a consequence of adding the new service type, we should also update the tests in test_communication to be aware of the new type (adding any test fixtures as needed).
The other option is to update the integration tests to not fail if they encounter an unknown message type, but I think it's worth adding tests to increase coverage for this case.

This was referenced Jul 16, 2019
Closed
Merged
@jacobperron jacobperron merged commit 52560fc into master Jul 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/arrays_srv branch July 20, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @dirk-thomas