Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composition #9

Closed
wants to merge 3 commits into from
Closed

Use composition #9

wants to merge 3 commits into from

Conversation

dhood
Copy link
Member

@dhood dhood commented Dec 16, 2016

WIP - working on services and parameters

@dhood dhood self-assigned this Dec 16, 2016
@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Dec 16, 2016
@dhood
Copy link
Member Author

dhood commented Dec 16, 2016

I feel like using composition is making the service and parameter examples quite a bit harder to follow. (pub-sub's not too bad)

Does anyone have an opinion on if this is worthwhile for tutorials? We might be better off sacrificing best practices for readability when we are presenting these topics for the first time.

@wjwwood
Copy link
Member

wjwwood commented Dec 16, 2016

Just to recap here, I think @dhood is going to migrate her comments/documentation to the composition demo: https://github.com/ros2/demos/blob/master/composition/src/listener_component.cpp and https://github.com/ros2/demos/blob/master/composition/src/talker_component.cpp

And @Karsten1987 is going to add service and client examples in the composition demos repository.

And then we're going to drop this repository from the repos file for beta 1 since we're not ready to make complete tutorials yet.

Is that how everyone else understood it?

@codebot
Copy link
Member

codebot commented Dec 16, 2016 via email

@dhood
Copy link
Member Author

dhood commented Dec 19, 2016

closing in favour of ros2/demos#97 and ros2/demos#95

@dhood dhood closed this Dec 19, 2016
@dhood dhood removed the in progress Actively being worked on (Kanban column) label Dec 19, 2016
@dhood dhood deleted the use-composition branch December 19, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants