Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to composition demo #97

Merged
merged 4 commits into from
Dec 19, 2016
Merged

Add comments to composition demo #97

merged 4 commits into from
Dec 19, 2016

Conversation

dhood
Copy link
Member

@dhood dhood commented Dec 19, 2016

No description provided.

@dhood dhood self-assigned this Dec 19, 2016
@dhood dhood added the in progress Actively being worked on (Kanban column) label Dec 19, 2016
@dhood dhood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 19, 2016
/**
* Create a callback function for when messages are received.
* Variations of this function also exist using, for example, UniquePtr for zero-copy transport.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be line comments rather then block comments. Doxygen (/**) would also not extract those I assume?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the other files.

I think this is good in order to avoid confusion with doxygen comments.
Doxygen would not have extract most of these anyways (since many are not attached functions, classes, or attribute declarations).
@wjwwood
Copy link
Member

wjwwood commented Dec 19, 2016

I updated this to use line comments in order to fix the inconsistent indentation and to avoid confusion with doxygen and to save vertical lines. I don't think we were planning on running doxygen on this anyways.

@dirk-thomas
Copy link
Member

Still one file with block comments.

@wjwwood
Copy link
Member

wjwwood commented Dec 19, 2016

It's fixed.

@wjwwood wjwwood merged commit 6fba5b0 into master Dec 19, 2016
@wjwwood wjwwood deleted the add-comments branch December 19, 2016 18:25
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Dec 19, 2016
@dhood
Copy link
Member Author

dhood commented Dec 21, 2016

Block comments are used in ROS 1 tutorials so I was following that
Thank you for iterating on this @wjwwood!

@wjwwood
Copy link
Member

wjwwood commented Dec 21, 2016

Block comments are used in ROS 1 tutorials so I was following that

Ah, that makes sense. I was just updating it to follow our developer guide:

Use /// and /** */ comments for documentation purposes and // style comments for notes and general comments

-- https://github.com/ros2/ros2/wiki/Developer-Guide#c-1

Both paths were probably fine, but I switched it when touching things to fix the indentation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants