Replace ros2cli repo by ros2cli_common_extensions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Aug 11, 2020
|
Thanks for the PR, this looks good to me. @ros2/team anyone else have thoughts here? |
dirk-thomas
approved these changes
Aug 11, 2020
|
We just have to be careful what to add to |
dirk-thomas
changed the title
wjwwood
approved these changes
Aug 11, 2020
|
Thanks for the feedback. I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That will also add argcomplete as a dependency ros2/ros2cli_common_extensions#3