Bugfix: Issue #2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Replace previous subprocess.run tests for the
oneimgfrcCLI withunittest.mocks.Fixes Issue #2
Description of changes
Replaced the previous
subprocess.runtests for the CLI as these tests failed with Github actions, though they worked when run locally.Now the tests for CLI use
unittest.mock, which simulate what would happen ifsys.argvwas set to the command list that was previously passed tosubprocess.run.For example,
running the following in the terminal
can be passed to
sys.argvas a list (len=7) in a mock patch.