Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTK4 #13

Merged
merged 3 commits into from
Apr 30, 2022
Merged

Add GTK4 #13

merged 3 commits into from
Apr 30, 2022

Conversation

ashbork
Copy link
Contributor

@ashbork ashbork commented Apr 30, 2022

Hi!
I managed to put together a libadwaita theme. The readme and releases will need to be updated if this PR gets merged, as I also changed the repo's structure according to @mvllow's recommendation. I'd be happy to help with that too.

@mvllow
Copy link
Member

mvllow commented Apr 30, 2022

Unfortunately this is too large for me to review on both the web and local (both error out before I'm able to view anything). Maybe @ThatOneCalculator can chime in 😌

@mvllow mvllow linked an issue Apr 30, 2022 that may be closed by this pull request
@ThatOneCalculator
Copy link
Member

I'll have to test this out when I have the chance, thank you!

@ThatOneCalculator
Copy link
Member

I'm looking at all the SVGs and everything on my phone, I've gotta say it looks like you did an incredible job! What did you use to make this @maybork ?

@ashbork
Copy link
Contributor Author

ashbork commented Apr 30, 2022

If you mean the icons, they're the ones that are currently in the repo, I just moved them to keep it more organized, I wouldn't dare attributing them to myself! To be fair, that simple change does make it seem like I did a lot more than just moving files, sorry, I'm pretty new to Git.

Of course, the structure could be changed if you wish - I just thought that it'd be way easier to follow the installation steps with the files divided across directories, especially since GTK4 and libadwaita means that there's another step necessary if we want a consistent user experience. I'll leave that decision up to you, though!

As for the creation of the GTK4 theme, this was way easier through the build tool - otherwise, the process is just defining a bunch of colors. Replacing one's ~/.config/gtk-4.0/gtk.css with one of the variants overrides the default libadwaita colors - no need for Tweaks. However, legacy apps still need a GTK3 theme (and you need to apply them through Tweaks).

@ThatOneCalculator
Copy link
Member

I keep trying to review it 😂
image

@ThatOneCalculator
Copy link
Member

From my testing it works great, I'll merge it for now and lyk if any more issues arise. Thank you for your work on this!

@ThatOneCalculator ThatOneCalculator merged commit 68e9297 into rose-pine:main Apr 30, 2022
@ThatOneCalculator ThatOneCalculator removed their request for review April 30, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add libadwaita theme and fix legacy theming
3 participants