Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken transparency for treesitter-context #294

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

sjclayton
Copy link
Contributor

@sjclayton sjclayton commented Jul 22, 2024

Fixes the broken transparency for treesitter-context background. These highlights were not added to transparency_highlights in the initial commit when support was first added.

@mvllow
Copy link
Member

mvllow commented Jul 22, 2024

Thanks :)

@mvllow mvllow merged commit 375ddbe into rose-pine:main Jul 22, 2024
@sjclayton sjclayton deleted the fix-treesitter-context-trans branch July 22, 2024 07:18
@bhuvneshuchiha
Copy link

hey @sjclayton

check this out
Screenshot 2024-07-22 at 5 07 52 PM

I want that there should be an option to set the nvim treesitter context transparecy to true, but the bg color of the auto completion menu should be there. Other themes such as toyonight storm and gruvbox give this option where if you set vim's float transparency vim.api.nvim_set_hl(0, "Float", { bg = "none" })
by doing this, the treesitter becomes transparent but we can have the autocompletion bg color which looks good on the theme.

@bhuvneshuchiha
Copy link

it would be good that other things go transparent but the autocompletion menu still has a background color you know.. That looks sick!!!

@sjclayton
Copy link
Contributor Author

@bhuvneshuchiha

From my understanding you want the treesitter-context transparency setting handled automatically... like it is now, after my fix. But you want the auto complete popup to keep it's non-transparent state even when transparency is enabled? Do I have that correct?

This would be something to have a discussion with @mvllow about.

@bhuvneshuchiha
Copy link

@sjclayton Absolutely sir!! Please make it happen sir I love rose pine, its just this small thing that gives me a hiccup in an otherwise perfect colorscheme. Would really appreciate if you can have something done for this feature request. Please !!

@sjclayton
Copy link
Contributor Author

@bhuvneshuchiha Can you go and open an issue for this feature request please... so we can keep relevant conversations there.

@bhuvneshuchiha
Copy link

Sure sir

VoxelPrismatic pushed a commit to VoxelPrismatic/sakurapine that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants