Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fzf-lua invisible selection #299

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

sjclayton
Copy link
Contributor

Found the offending highlight groups and corrected them. 😄

Closes #283

Result:

2024-07-23_11-21

lua/rose-pine.lua Outdated Show resolved Hide resolved
This works the same as the original fix, confirmed by testing
against nvim 0.10.0 and nightly.

Prefer linking over previous solution.
@mirsella
Copy link

hey ! thanks for the awesome work ! in case the maintainer doesnt look at the update on the issue, for now this pr doesn't fix the issue, lets wait before merging it

@sjclayton sjclayton marked this pull request as draft July 23, 2024 16:39
@sjclayton
Copy link
Contributor Author

sjclayton commented Jul 23, 2024

@mirsella

I installed fzf-lua, and this is what I have on NVIM v0.11.0-dev-486+g9793a9777

2024-07-23_12-41

If you are on the latest nightly or even try nvim stable 0.10.0... they both look exactly the same. If yours doesn't look like the above then there is something getting overridden somewhere in your config.

Need to be on this commit atleast - 483983d

@mirsella
Copy link

update this PR is working as expected, it was a problem on my setup !

@sjclayton sjclayton marked this pull request as ready for review July 23, 2024 17:11
@sjclayton
Copy link
Contributor Author

sjclayton commented Jul 23, 2024

@mvllow

All good to merge it appears.

@mvllow mvllow merged commit 0f5635c into rose-pine:main Jul 23, 2024
@mvllow
Copy link
Member

mvllow commented Jul 23, 2024

Thanks everyone :)

@sjclayton sjclayton deleted the fix-fzflua-invisible-selection branch July 24, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: fzf-lua text invisible
3 participants