fix: solve data race #234
Merged
fix: solve data race #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jeremy-Run
commented
Jul 28, 2023
Jeremy-Run
commented
- solve data race
- modify annotation
|
Thanks, then |
|
yes |
roseduan
reviewed
Jul 28, 2023
| }() | ||
| } | ||
| wg.Wait() | ||
| } |
There was a problem hiding this comment.
Add some assertions after the concurrent put is done.
like Assert.equal(100, KeysNum)
roseduan
reviewed
Jul 28, 2023
batch.go
Outdated
| @@ -16,7 +16,7 @@ import ( | |||
| // If readonly is false, you can use Put and Delete method to write data to the batch. | |||
| // The data will be written to the database when you call Commit method. | |||
| // | |||
| // Batch is not a transaction, it does not guarantee isolation. | |||
| // Batch is not a transaction, it does not guarantee isolation(only guarantee read committed). | |||
There was a problem hiding this comment.
It`s not a very accurate description, actually, the isolation is Serializable because we have a global lock.
There was a problem hiding this comment.
I was thinking about this problem just now, I will delete it.
roseduan
reviewed
Jul 28, 2023
| @@ -174,8 +174,8 @@ func TestDB_Merge_6_Appending(t *testing.T) { | |||
| for i := 0; i < 10000; i++ { | |||
| key := utils.GetTestKey(rand.Int()) | |||
| m.Store(string(key), struct{}{}) | |||
| err = db.Put(key, utils.RandomValue(128)) | |||
| assert.Nil(t, err) | |||
| e := db.Put(key, utils.RandomValue(128)) | |||
There was a problem hiding this comment.
Yes, it's necessary. There are two data race points, this is one.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.