Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Update to android_core 0.4.0 #79

Merged
merged 3 commits into from
Dec 26, 2018

Conversation

jubeira
Copy link

@jubeira jubeira commented Oct 4, 2018

This is required for rosjava/android_apps#80 to work properly; otherwise the dependency chain breaks:

  • android_apps 0.4 --> android_core 0.4 and
  • android_apps 0.4 --> android_remocons 0.2 --> android_core 0.3.

If android_remocons still use the old android_core, android_apps cannot be compiled. With this change, android_remocons also will also depend on android_core 0.4

@jubeira
Copy link
Author

jubeira commented Oct 4, 2018

@ernestmc Same as rosjava/android_core#286 (comment); to build this before merging android_core, replace the buildscript block in the top level Gradle script with this:

// Replace external buildscript with this:
buildscript {
  apply from: "https://github.com/jubeira/rosjava_bootstrap/raw/task/add_google_repo/buildscript.gradle"
  dependencies {
    classpath "com.android.tools.build:gradle:3.2.0"
  }
}

apply plugin: 'catkin'

// Add the repositories block here
allprojects {
  group 'com.github.rosjava.android_remocons'
  version = project.catkin.pkg.version
  repositories {
    google()
    jcenter()
  }
}

After merging the PR in android_core this one should build without that hack.

@jubeira jubeira merged commit cfd4e91 into rosjava:kinetic Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants